refactor: Move arrow key shortcuts into their own class. #304
Conversation
rachel-fenichel
left a comment
rachel-fenichel
left a comment
There was a problem hiding this comment.
Note: hold off on merging until Ben's current focus changes land.
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
Per my remarks on #274—see also this lengthy discussion about cursor actions—I think the actions should be named after the cursor keys they are bound to.
(And we should in due course refactor the cursors so that their APIs are also directional, with each cursor being responsible for mapping from arrow direction to AST directions depending on LTR, flyout layout, etc.)
|
To be clear, you want separate |
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
To be clear, you want separate
LeftAction,RightAction,UpActionandDownActionclasses/files?
No, not at all. I just think we should rename the actions (id, name, description, etc.) to up/down/left/right, rather than prev/next/out/in.
(I think we should also rename the corresponding methods on the cursors, but that can be done as part of a subsequent PR that actually makes them RTL / horizontal flyout aware.)
|
Got it, thanks for clarifying! Updated accordingly (and also removed other deleted actions from |
This PR fixes #296 by moving the left/right/up/down arrow key actions out of navigation_controller.ts and into their own class.